linux-kernel - Re: scsi: aic7xxx hang since v2.6.28-rc1 ...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090219202317.GA784@elte.hu>
Date:	Thu, 19 Feb 2009 21:23:17 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	linux-scsi@...r.kernel.org,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Jens Axboe <jens.axboe@...cle.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>, linux-kernel@...r.kernel.org
Subject: Re: scsi: aic7xxx hang since v2.6.28-rc1 ...


* Alan Stern <stern@...land.harvard.edu> wrote:

> On Wed, 18 Feb 2009, Ingo Molnar wrote:
> 
> > 
> > * Alan Stern <stern@...land.harvard.edu> wrote:
> > 
> > > I have no idea if this will make any difference for the 
> > > problem you're seeing, but it has been submitted and it's 
> > > worth trying out.  If the problem still occurs, I'll write a 
> > > diagnostic patch to add log messages giving the destiny of 
> > > each request in scsi_io_completion().
> > 
> > OK, i've undone the reverts and have applied your fix - it will 
> > take a few hours to see whether the hang still occurs.
> 
> Any definitive results yet?

Yes, as i wrote before, the bug is fixed.

> It turns out that the patch I posted earlier is not quite 
> correct; the "__scsi_release_buffers(cmd, 0);" line in 
> scsi_end_request() was added after the patch was first written 
> and then got lost during rebasing.

Yeah, rebasing is a really bad idea in general.

> If this really does fix your problem and nobody has any other 
> objections to it, I'll submit a revised version with the 
> missing line added back in.

Sure, no objections.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/