| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20090219124418.dfc4dc9a.akpm@linux-foundation.org>
Date: Thu, 19 Feb 2009 12:44:18 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Nicolas Pitre <nico@....org>
Cc: drzeus-mmc@...eus.cx, linux-kernel@...r.kernel.org,
Maen Suleiman <maen@...vell.com>
Subject: Re: [PATCH] SDIO driver for Marvell SoCs
On Tue, 17 Feb 2009 23:46:21 -0500 (EST)
Nicolas Pitre <nico@....org> wrote:
> From: Maen Suleiman <maen@...vell.com>
>
> This supports MMC/SD/SDIO currently found on the Kirkwood 88F6281 and
> 88F6192 SoC controllers.
>
> Signed-off-by: Nicolas Pitre <nico@...vell.com>
It would be nice to have Maen's signoff.
>
> ...
>
> +#define mvsd_write(offs, val) writel(val, iobase + (offs))
> +#define mvsd_read(offs) readl(iobase + (offs))
It's rather grotty to have a macro which secretly relies upon the
presence of a particularly-named local variable.
>
> ...
>
> +static int __init mvsd_probe(struct platform_device *pdev)
> +{
> + struct mmc_host *mmc = NULL;
> + struct mvsd_host *host = NULL;
> + const struct mvsdio_platform_data *mvsd_data;
> + struct resource *r;
> + int ret, irq;
> +
> + r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + irq = platform_get_irq(pdev, 0);
> + mvsd_data = pdev->dev.platform_data;
> + if (!r || irq < 0 || !mvsd_data)
> + return -ENXIO;
> +
> + r = request_mem_region(r->start, SZ_1K, DRIVER_NAME);
> + if (!r)
> + return -EBUSY;
> +
> + mmc = mmc_alloc_host(sizeof(struct mvsd_host), &pdev->dev);
> + if (!mmc) {
> + ret = -ENOMEM;
> + goto out;
Resource `r' is leaked here.
> + }
> +
> + host = mmc_priv(mmc);
> + host->mmc = mmc;
> + host->dev = &pdev->dev;
> + host->res = r;
> + host->base_clock = mvsd_data->clock / 2;
> +
> + mmc->ops = &mvsd_ops;
> +
> + mmc->ocr_avail = MMC_VDD_32_33 | MMC_VDD_33_34;
> + mmc->caps = MMC_CAP_4_BIT_DATA | MMC_CAP_SDIO_IRQ |
> + MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
> +
> + mmc->f_min = DIV_ROUND_UP(host->base_clock, MVSD_BASE_DIV_MAX);
> + mmc->f_max = maxfreq;
> +
> + mmc->max_blk_size = 2048;
> + mmc->max_blk_count = 65535;
> +
> + mmc->max_hw_segs = 1;
> + mmc->max_phys_segs = 1;
> + mmc->max_seg_size = mmc->max_blk_size * mmc->max_blk_count;
> + mmc->max_req_size = mmc->max_blk_size * mmc->max_blk_count;
> +
> + spin_lock_init(&host->lock);
> +
> + host->base = ioremap(r->start, SZ_4K);
> + if (!host->base) {
> + ret = -ENOMEM;
> + goto out;
> + }
> +
> + /* (Re-)program MBUS remapping windows if we are asked to. */
> + if (mvsd_data->dram != NULL)
> + mv_conf_mbus_windows(host, mvsd_data->dram);
> +
> + mvsd_power_down(host);
> +
> + ret = request_irq(irq, mvsd_irq, 0, DRIVER_NAME, host);
> + if (ret) {
> + printk(KERN_ERR "%s: cannot assign irq %d\n", DRIVER_NAME, irq);
> + goto out;
> + } else
> + host->irq = irq;
> +
> + if (mvsd_data->gpio_card_detect) {
> + ret = gpio_request(mvsd_data->gpio_card_detect,
> + DRIVER_NAME " cd");
> + if (ret == 0) {
> + irq = gpio_to_irq(mvsd_data->gpio_card_detect);
> + ret = request_irq(irq, mvsd_card_detect_irq,
> + IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING,
> + DRIVER_NAME " cd", host);
> + if (ret == 0)
> + host->gpio_card_detect =
> + mvsd_data->gpio_card_detect;
> + else
> + gpio_free(mvsd_data->gpio_card_detect);
> + }
> + }
> + if (!host->gpio_card_detect)
> + mmc->caps |= MMC_CAP_NEEDS_POLL;
> +
> + if (mvsd_data->gpio_write_protect) {
> + ret = gpio_request(mvsd_data->gpio_write_protect,
> + DRIVER_NAME " wp");
> + if (ret == 0) {
> + gpio_direction_input(mvsd_data->gpio_write_protect);
> + host->gpio_write_protect =
> + mvsd_data->gpio_write_protect;
> + }
> + }
> +
> + setup_timer(&host->timer, mvsd_timeout_timer, (unsigned long)host);
> + platform_set_drvdata(pdev, mmc);
> + ret = mmc_add_host(mmc);
> + if (ret)
> + goto out;
> + return 0;
> +
> +out:
> + if (host) {
> + if (host->irq)
> + free_irq(host->irq, host);
> + if (host->gpio_card_detect) {
> + free_irq(gpio_to_irq(host->gpio_card_detect), host);
> + gpio_free(host->gpio_card_detect);
> + }
> + if (host->gpio_write_protect)
> + gpio_free(host->gpio_write_protect);
> + if (host->base)
> + iounmap(host->base);
> + if (host->res)
> + release_resource(host->res);
> + }
> + if (mmc)
> + mmc_free_host(mmc);
> +
> + return ret;
> +}
> +
> +static int __exit mvsd_remove(struct platform_device *pdev)
> +{
> + struct mmc_host *mmc = platform_get_drvdata(pdev);
> +
> + if (mmc) {
> + struct mvsd_host *host = mmc_priv(mmc);
> +
> + if (host->gpio_card_detect) {
> + free_irq(gpio_to_irq(host->gpio_card_detect), host);
> + gpio_free(host->gpio_card_detect);
> + }
> + mmc_remove_host(mmc);
> + free_irq(host->irq, host);
> + if (host->gpio_write_protect)
> + gpio_free(host->gpio_write_protect);
> + del_timer_sync(&host->timer);
> + mvsd_power_down(host);
> + iounmap(host->base);
> + release_resource(host->res);
> + mmc_free_host(mmc);
Perhaps this function and the error path ("out:") in the preceding
function could share code.
> + }
> + platform_set_drvdata(pdev, NULL);
> + return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists