linux-kernel - Re: [patch 03/36] Fix Intel IOMMU write-buffer flushing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:  <499DF274.8040702@mandriva.org>
Date:	Fri, 20 Feb 2009 01:59:48 +0200
From:	Thomas Backlund <tmb@...driva.org>
To:	linux-kernel@...r.kernel.org
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	stable@...nel.org, Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	Theodore Ts'o <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>,
	Chuck Ebbert <cebbert@...hat.com>,
	Domenico Andreoli <cavokz@...il.com>, Willy Tarreau <w@....eu>,
	Rodrigo Rubira Branco <rbranco@...checkpoint.com>,
	Jake Edge <jake@....net>, Eugene Teo <eteo@...hat.com>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk,
	David Woodhouse <David.Woodhouse@...el.com>
Subject:  Re: [patch 03/36] Fix Intel IOMMU write-buffer flushing

Thomas Backlund skrev:
> This patch is broken compared to what's in:
> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ca77fde8e62cecb2c0769052228d15b901367af8 
> 
> 
> attached patch fixes it
> 

As no-one responded yet...

I forgot to tell how to reproduce it:

on x86_64:

make defconfig
make

and you will end up with:
[thomas@tmb linux-2.6.27.19-rc1]$ LC_ALL=C make
   CHK     include/linux/version.h
   CHK     include/linux/utsrelease.h
   CALL    scripts/checksyscalls.sh
   CHK     include/linux/compile.h
   CC      drivers/pci/intel-iommu.o
drivers/pci/intel-iommu.c: In function 'iommu_flush_write_buffer':
drivers/pci/intel-iommu.c:530: error: 'rwbf_quirk' undeclared (first use 
in this function)
drivers/pci/intel-iommu.c:530: error: (Each undeclared identifier is 
reported only once
drivers/pci/intel-iommu.c:530: error: for each function it appears in.)
make[2]: *** [drivers/pci/intel-iommu.o] Error 1
make[1]: *** [drivers/pci] Error 2
make: *** [drivers] Error 2
[thomas@tmb linux-2.6.27.19-rc1]$

This happends because 'rwbf_quirk' is declared after it's first use.

The upstream git has 'rwbf_quirk' declared before any use of it.

That's what my patch fixes, by simply moving

static int rwbf_quirk = 0;

to the beginning of the file...

Hopefully this helps.
--
Thomas


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/