linux-kernel - Re: [PATCH] x86: enable x2apic early at the first point

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090220094123.GJ24555@elte.hu>
Date:	Fri, 20 Feb 2009 10:41:23 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Gleb Natapov <gleb@...hat.com>
Cc:	Suresh Siddha <suresh.b.siddha@...el.com>,
	Yinghai Lu <yinghai@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: enable x2apic early at the first point


* Gleb Natapov <gleb@...hat.com> wrote:

> > > I will post couple of patches, which revert's Gleb's patch 
> > > and another fix for the early boot failure issue, 
> > > tomorrow.
> 
> If you'll revert my patch it will not be possible to use 
> x2apic in KVM (at least without KVM implementing interrupt 
> remapping which is unneeded otherwise) and x2apic interface is 
> much better for vitalization. Instead of reverting the patch 
> it will be better to add check if x2apic can be used without 
> intr-remmaping (all CPUs belong to cluster 0) or allow 
> enabling of x2apic without IR if running as a guest.

yep, that would be required - because your patch can break real 
systems right now. Mind sending me a fix for it?

I've applied Yinghai's fix as well, so please base it on latest 
tip:master.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/