linux-kernel - Re: [git pull] x86 page fault checker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0902201100280.29217@gandalf.stny.rr.com>
Date:	Fri, 20 Feb 2009 11:00:44 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [git pull] x86 page fault checker


On Fri, 20 Feb 2009, Ingo Molnar wrote:
> > -	return spurious_fault_check(error_code, pte);
> > +	ret = spurious_fault_check(error_code, pte);
> > +	if (!ret)
> > +		return 0;
> > +
> > +	/*
> > +	 * Make sure we have permissions in PMD
> > +	 * If not, then there's a bug in the page tables.
> > +	 */
> > +	ret = spurious_fault_check(error_code, (pte_t *) pmd);
> > +	WARN_ON(!ret);
> > +	return ret;
> >  }
> 
> i guess we could do this - but i'd rather have it as a 
> WARN_ONCE(), with some text - so that if it ever triggers it's 
> one surgical message.

OK, I'll make this update and rebase it.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/