linux-kernel - Re: x86, vmi: TSC going backwards check in vmi clocksource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090220175841.GQ24538@elte.hu>
Date:	Fri, 20 Feb 2009 18:58:41 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Alok Kataria <akataria@...are.com>
Cc:	the arch/x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Zachary Amsden <zach@...are.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: x86, vmi: TSC going backwards check in vmi clocksource


* Alok Kataria <akataria@...are.com> wrote:

>  static cycle_t read_real_cycles(void)
>  {
> -	return vmi_timer_ops.get_cycle_counter(VMI_CYCLES_REAL);
> +	cycle_t ret = (cycle_t)vmi_timer_ops.get_cycle_counter(VMI_CYCLES_REAL);
> +	return ret >= clocksource_vmi.cycle_last ?
> +		ret : clocksource_vmi.cycle_last;

btw., could you please clean this up to use max()?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/