linux-kernel - Re: state of some x86 acpi patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12c511ca0902201354q738f2f91hd94a5e9826e0696f@mail.gmail.com>
Date:	Fri, 20 Feb 2009 13:54:05 -0800
From:	Tony Luck <tony.luck@...el.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Jeremy Fitzhardinge <jeremy@...p.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: state of some x86 acpi patches

On Sun, Feb 15, 2009 at 3:10 PM, Yinghai Lu <yinghai@...nel.org> wrote:
> Index: linux-2.6/arch/ia64/kernel/acpi.c
> ===================================================================
> --- linux-2.6.orig/arch/ia64/kernel/acpi.c
> +++ linux-2.6/arch/ia64/kernel/acpi.c
> @@ -199,7 +199,7 @@ char *__init __acpi_map_table(unsigned l
>        return __va(phys_addr);
>  }
>
> -char *__init __acpi_unmap_table(unsigned long virt_addr, unsigned long size)
> +void __init __acpi_unmap_table(char *map, unsigned long size)
>  {
>  }

I'm seeing some section mismatch warnings for this function (when building
linux-next tag: next-20090220) as it is called by some non __init functions:

WARNING: vmlinux.o(.text+0x498912): Section mismatch in reference from
the function early_acpi_os_unmap_memory() to the function
.init.text:__acpi_unmap_table()

WARNING: vmlinux.o(.text+0x4989a2): Section mismatch in reference from
the function acpi_os_unmap_memory() to the function
.init.text:__acpi_unmap_table()

Simplest solution would seem to be dropping the "__init" (since the
function is empty, it won't bloat the kernel by much if we don't manage
to free up the memory - just 32 bytes :-)

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/