linux-kernel - Re: Incorrect #ifdef in arch/x86/mm/pat.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090220225857.GA6042@elte.hu>
Date:	Fri, 20 Feb 2009 23:58:57 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Dheeraj Reddy <dheerajr@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: Incorrect #ifdef in arch/x86/mm/pat.c


* Dheeraj Reddy <dheerajr@...il.com> wrote:

> Hello there,
>     The checks for reading /dev/kmem and /dev/mem in arch/x86/mm/pat.c seems to 
> be incorrect when CONFIG_STRICT_DEVMEM is set.
> Following patch corrects it.
> The check should always return 1 when CONFIG_STRICT_DEVMEM is not defined, 
> similar to what is in drivers/char/mem.c

no - see the comment in pat.c:

/* This check is done in drivers/char/mem.c in case of STRICT_DEVMEM*/

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/