linux-kernel - Re: [PATCH 2/4] forget_original_parent: do not abuse child->ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Feb 2009 18:28:23 -0800 (PST)
From:	Roland McGrath <roland@...hat.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Metzger, Markus T" <markus.t.metzger@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] forget_original_parent: do not abuse
	child->ptrace_entry

> - rename ptrace_dead to dead_childs.

s/dead_childs/dead_children/

> Actually, I don't understand why do we notify /sbin/init when we
> reparent a zombie, probably it is better to reap it unconditionally.

It is traditional behavior.  It gives the init implementation the option to
report/log/analyze the details of abandoned zombies.  (Whether or not that
really seems useful, there is no good reason to restrict the possibility.)

> +/*
> +* Any that need to be release_task'd are put on the @dead list.
> + */

Missing leading space on the second comment lien.

Modulo those cosmetic things, ACK on this.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/