linux-kernel - Re: [malware-list] [PATCHv2 3/5] VFS: DazukoFS, stackable-fs, file access control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090221191124.238743a4@humpdell>
Date:	Sat, 21 Feb 2009 19:11:24 +0100
From:	Frantisek Hrbata <frantisek.hrbata@....com>
To:	John Ogness <dazukocode@...ess.net>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"hch@...radead.org" <hch@...radead.org>,
	"alan@...rguk.ukuu.org.uk" <alan@...rguk.ukuu.org.uk>,
	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
	"malware-list@...ts.printk.net" <malware-list@...ts.printk.net>
Subject: Re: [malware-list] [PATCHv2 3/5] VFS: DazukoFS, stackable-fs,	file
 access control

On Tue, 3 Feb 2009 20:18:29 +0100
John Ogness <dazukocode@...ess.net> wrote:

> +/**
> + * dazukofs_add_group - add a new group
> + * @name: the name of the group to add
> + *
> + * Description: This function is called by the device layer to add a new
> + * group. It returns success if the group has been successfully created
> + * or if the group already exists.
> + *
> + * Returns 0 on success.
> + */
> +int dazukofs_add_group(const char *name)
> +{
> +       int ret = 0;
> +       int already_exists;
> +       int available_id = 0;
> +       struct dazukofs_group *grp;
> +
> +       write_lock(&group_count_rwlock);
> +
> +       mutex_lock(&work_mutex);

Hi,

you cannot hold spinlock and try to acquire mutex.

write_lock() -> preempt_disable() vs mutex_lock -> schedule()

-FH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/