linux-kernel - Fwd: PCF8583 not detected on RiscPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090221194814.GA24385@n2100.arm.linux.org.uk>
Date:	Sat, 21 Feb 2009 19:48:14 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Jean Delvare <khali@...ux-fr.org>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Juergen Beisert <j.beisert@...gutronix.de>,
	Alessandro Zummo <a.zummo@...ertech.it>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ben Dooks <ben-linux-arm@...ff.org>,
	linux-kernel@...r.kernel.org
Subject: Fwd: PCF8583 not detected on RiscPC

Previous mail sent just to Jean:

| Any ideas why the RTC isn't being detected on the ARM RiscPC platform?
| 
| Could it be because someone's decided to regress stuff because of having
| an i2c_boardinfo structure without actually first making sure everything
| is converted over?
| 
| If yes, what do I need to do to make it work?  (IOW, please supply a
| patch to fix the regression or explain in detail what's required to make
| it work.)

To summarise the situation, the bus driver is:

drivers/i2c/busses/i2c-acorn.c

which is not a platform driver.  It is not initialised by the platform
code.  It does not provide i2c_boarddata or whatever the funky name for
that feature is.

However, PCF8583 got converted to require i2c_boarddata without first
fixing up the platform which uses it, thereby making the driver utterly
useless.

Putting i2c_boarddata into i2c-acorn.c feels wrong.

So, please either revert 02bb584f3b1cfc8188522a4d2c8881b65073a4f1 so
that the regression can be fixed (no RTC on Acorn RiscPC machines) or
provide a patch which fixes this mess that the above change causes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/