linux-kernel - Re: [PATCH] fs/cifs: send SMB_COM_FLUSH in cifs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <524f69650902201721l1c7f0d34p4708980a90d7fc8f@mail.gmail.com>
Date:	Fri, 20 Feb 2009 19:21:05 -0600
From:	Steve French <smfrench@...il.com>
To:	Horst Reiterer <horst.reiterer@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-cifs-client@...ts.samba.org
Subject: Re: [PATCH] fs/cifs: send SMB_COM_FLUSH in cifs_fsync

On Fri, Feb 20, 2009 at 2:51 PM, Horst Reiterer
<horst.reiterer@...il.com> wrote:
> Hi,
>
> In contrast to the now-obsolete smbfs, cifs does not send SMB_COM_FLUSH
> in response to an explicit fsync(2) to guarantee that all volatile data
> is written to stable storage on the server side, provided the server
> honors the request (which, to my knowledge, is true for Windows and
> Samba with 'strict sync' enabled).
> This patch modifies the cifs_fsync implementation

I modified your patch slightly to not lose the writeback rc in one
case, and to change camel case pTcon to tcon and remove one
unnecessary local variable.

See attached.   Thanks for the submission - looks fine otherwise.   If
you have any performance numbers before and after (with e.g. dbench,
iozone, bonnie etc. or perhaps something which calls fsync more often
- that would be helpful in determining whether we need a mount option
to optionally disable it - as the samba server does)


-- 
Thanks,

Steve

View attachment "fsync.patch" of type "text/x-diff" (4794 bytes)