linux-kernel - Re: [PATCH v2] kconfig: check for select dependency errors on config load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 21 Feb 2009 22:51:04 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-kbuild@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>, zippel@...ux-m68k.org
Subject: Re: [PATCH v2] kconfig: check for select dependency errors on config load

On Sat, Feb 21, 2009 at 03:46:29PM -0500, Steven Rostedt wrote:
> 
> On Sat, 21 Feb 2009, Steven Rostedt wrote:
> > On Fri, 20 Feb 2009, Randy Dunlap wrote:
> > > EMBEDDED is misnamed.  It means "those who think that they know enough
> > > to use all of the power of kconfig."
> > > Some people spell that EXPERT etc.
> > > Or it means "let me shoot myself in the foot."
> 
> > 
> > Anyway, to avoid having these spit out all the time, I'll see if I can 
> > make it not warn if the dependency was on EMBEDDED/EXPERT. I'll try to 
> > work on it when I have time.
> 
> That was easier than I expected. Here's an updated version of the patch.
> 
> It now finds the symbol EMBEDDED, saves its state. Updates its state to 
> 'yes', runs the tests, resets its state back to what it was.

We do not want to have such hardcoded information
about the Kconfig structure in the backend.
Rather we should fix the configuration once and for all so EMBEDDED
get split into the sensible options is actually is.

Options that come to my mind is:
OPTIMIZE_FOR_TEXT_SIZE
OPTIMIZE_FOR_DATA_SIZE
KERNEL_EXPERT

And we should them make their use of select conform
like the rest of the kernel configuration.

So the first version of your patch is IMO better - but
it could use some comments so others better follows what is
going on. The current level of comments in the kconfig
source base is not an example to follw

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/