linux-kernel - Re: [PATCH 1/1] edac x38: new MC driver module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 22 Feb 2009 23:21:14 +0900
From:	Hitoshi Mitake <h.mitake@...il.com>
To:	Sam Ravnborg <sam@...nborg.org>, davem@...emloft.net
Cc:	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"Luck, Tony" <tony.luck@...el.com>,
	Russell King <rmk+lkml@....linux.org.uk>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Doug Thompson <norsk5@...oo.com>, dougthompson@...ssion.com,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 1/1] edac x38: new MC driver module

On Sat, 21 Feb 2009 14:09:37 +0100
Sam Ravnborg <sam@...nborg.org> wrote:

> > Hi,
> > 
> > Very sorry for long distance between my previous post and this...
> > 
> > I wrote a patch to add HAVE_READQ and HAVE_WRITEQ to each architecture's Kconfig file
> > which have readq() and writeq().
> > 
> > But there is problem.
> > I wrote helps for HAVE_READQ and HAVE_WRITEQ in Kconfig file
> > accodring to the advice by Russell King ( http://marc.info/?l=linux-kernel&m=122701161824218&w=2 ),
> > but these helps are invisible when I doing menuconfig.
> > (when type '/' and search readq string, HAVE_READQ found, but
> > help string is not printed...)
> > 
> > Do you have some nice technique that make these helps visible easily?
> 
> The options are not visible in menuconfig and therefore the is not
> much point in displaying help for them thre when you search for the symbol.
> But the help contained in the KConfig file is fully justified as it is
> now documented why/when to select these options.
> 
> 	Sam

description of the patch: Adding HAVE_READQ, HAVE_WRITEQ and their help texts
to each architecture's Kconfig file which have readq() and writeq().

Signed-off-by: Hitoshi Mitake <h.mitake@...il.com>

---
 arch/sparc/Kconfig |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)

diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index c3ea215..eb5efa3 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -527,3 +527,23 @@ source "security/Kconfig"
 source "crypto/Kconfig"
 
 source "lib/Kconfig"
+
+config HAVE_READQ
+	def_bool y
+	depends on SPARC64
+	help
+	  This is a sign to represent that this architecture provides
+	  readq() function. readq() is a function to read 8 bytes from
+	  I/O space. Each drivers use readq() must depend on this symbol.
+	  Because lots of little private readq() implementations
+	  all over the tree is sucks.
+
+config HAVE_WRITEQ
+	def_bool y
+	depends on SPARC64
+	help
+	  This is a sign to represent that this architecture provides
+	  writeq() function. writeq() is a function to read 8 bytes from
+	  I/O space. Each drivers use writeq() must depend on this symbol.
+	  Because lots of little private writeq() implementations
+	  all over the tree is sucks.
-- 
1.6.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/