linux-kernel - Re: Fwd: PCF8583 not detected on RiscPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090222112654.GC28025@n2100.arm.linux.org.uk>
Date:	Sun, 22 Feb 2009 11:26:54 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Alessandro Zummo <alessandro.zummo@...ertech.it>
Cc:	Jean Delvare <khali@...ux-fr.org>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Juergen Beisert <j.beisert@...gutronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ben Dooks <ben-linux-arm@...ff.org>,
	linux-kernel@...r.kernel.org
Subject: Re: Fwd: PCF8583 not detected on RiscPC

On Sun, Feb 22, 2009 at 11:35:44AM +0100, Alessandro Zummo wrote:
> On Sun, 22 Feb 2009 09:51:50 +0000
> Russell King - ARM Linux <linux@....linux.org.uk> wrote:
> > >   That's very simple, even if acorn is a bit unstructured. You just
> > >  need to choice a place under arch/arm that you like
> > >  (arch/arm/plat-acorn/ ? ) and place a bit of code called
> > >  by an appropriate initcall. 
> > 
> > Thanks.
> > 
> > If it is as simple as you are suggesting, why wasn't it done _before_
> > breaking the RTC support?
> 
>  I guess because who did the modification didn't know
>  it was used on acorn and nor did I.
> 
>  
> > After all, you know damned well that PCF8583 is used on ARM and you
> > know the config symbol for the platform, especially as you pointedly
> > remove the dependencies on CONFIG_ARCH_RPC from the driver inspite of
>  
>  ????

I refer you to bb71f99f8daefb4a2c2441298bc127aaff9af947 and the
discussion resulting from that commit, and changed in your commit
09a21e56dc3767ce444e21c1383d587b261af13c.

>  I don't know who converted the acorn platform to
>  use it and I can't care less. Who did should have checked the driver 
>  for compatibility with his own platform before migrating from the driver under
>  drivers/char/ .

Which bit of "it used to work" did you miss?  At the time of converesion,
it was checked and after some initial trivial bug fixing and it was
working, and continued to work up until this recent breakage.

>  As far as I can see with git log, you applied changes to the driver
>  multiple times, without having me in Cc nor G. Liakhovetski (who did
>  the port).

I don't add CC entries to commits, so you can't make that assumption.
However, I did talk to Guennadi around the time of those changes about
some of the issues therein, in particular adding back the I2C address of
the PCF8583.

Most of those other changes were trivial bug fixes, and I do apologise
for not copying you with those.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/