linux-kernel - Re: [PATCH] init/main.c: fix sparse warnings: context imbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49A148F7.1010302@s5r6.in-berlin.de>
Date:	Sun, 22 Feb 2009 13:45:43 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Hannes Eder <hannes@...neseder.net>
CC:	Ingo Molnar <mingo@...e.hu>, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] init/main.c: fix sparse warnings: context imbalance

Stefan Richter wrote:
> Hannes Eder wrote:
>> On Sun, Feb 22, 2009 at 12:30 PM, Stefan Richter
>> <stefanr@...6.in-berlin.de> wrote:
>>> It is not a fix, it's merely an annotation.
>> This patch 'better word for fix's a warning reported by sparse. What
>> better wording would you suggest?
> 
> "annotate init_post() as releasing the BKL" or whatever in the title,
> furthermore "Removes the following sparse warnings: ..." in the changelog.

PS:  In some sense it is indeed a "fix" for the high-level problem that
sparse can't guess whether the context imbalance is correct or not.  The
original warning from sparse was correct in itself.  Your annotation
enables sparse to warn if problems outside the scope of the single
function occur (I guess).  So it's more a maintainabiliy improvement
than a fix.
-- 
Stefan Richter
-=====-==--= --=- =-==-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/