linux-kernel - Re: [linux-cifs-client] Re: [PATCH] fs/cifs: send SMB_COM_FLUSH in cifs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090222181052.36763a2d@tupile.poochiereds.net>
Date:	Sun, 22 Feb 2009 18:10:52 -0800
From:	Jeff Layton <jlayton@...hat.com>
To:	Jeff Layton <jlayton@...hat.com>
Cc:	Horst Reiterer <horst.reiterer@...il.com>,
	Steve French <smfrench@...il.com>,
	linux-cifs-client@...ts.samba.org, linux-kernel@...r.kernel.org
Subject: Re: [linux-cifs-client] Re: [PATCH] fs/cifs: send SMB_COM_FLUSH in
 cifs_fsync

On Sun, 22 Feb 2009 17:34:46 -0800
Jeff Layton <jlayton@...hat.com> wrote:

> On Sun, 22 Feb 2009 22:12:11 +0100 (CET)
> Horst Reiterer <horst.reiterer@...il.com> wrote:
> 
> > On Sun, 22 Feb 2009, Steve French wrote:
> > > Suggestions on what to call such a new mount option?  How about
> > > "nostrictfsync"  ?
> > 
> > Sound good, should be self-explanatory for Samba users and those familiar
> > with the fsync concept.
> > 
> > Horst.
> 
> My suggestion would be to not add a new option until someone requests
> it/complains about it. We already have a lot of unneeded/unused mount
> options, and I think this will just be adding one to the pile.
> 
> My $.02...
> 

...and to lend further strength to this argument, we're not doing this
at close(), but rather at fsync(). posix is pretty clear about what's
supposed to happen at fsync:

"The fsync() function shall request that all data for the open file
descriptor named by fildes is to be transferred to the storage device
associated with the file described by fildes."

...if you don't want to take the performance penalty then don't use
fsync(). If you're using fsync, then you care about data integrity
and adding a mount option to disable it is rather pointless.

-- 
Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/