linux-kernel - Re: checkpatch --file warns about p0 patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090223144312.GC22617@shadowen.org>
Date:	Mon, 23 Feb 2009 14:43:12 +0000
From:	Andy Whitcroft <apw@...onical.com>
To:	Mike Rapoport <mike@...pulab.co.il>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: checkpatch --file warns about p0 patch

On Mon, Feb 23, 2009 at 04:20:21PM +0200, Mike Rapoport wrote:
> When running checkpatch.pl with --file option it warns about -p0 patch:
> 
> ./scripts/checkpatch.pl --file ./drivers/rtc/rtc-v3020.c
> WARNING: patch prefix '.' exists, appears to be a -p0 patch
> 
> total: 0 errors, 1 warnings, 263 lines checked
> 
> ./drivers/rtc/rtc-v3020.c has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> I hope this is the fix that'll work:
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 45eb0ae..1869388 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1240,7 +1240,7 @@ sub process {
>  			$realfile =~ s@^([^/]*)/@@;
> 
>  			$p1_prefix = $1;
> -			if ($tree && $p1_prefix ne '' && -e "$root/$p1_prefix") {
> +			if (!$file && $tree && $p1_prefix ne '' && -e "$root/$p1_prefix") {
>  				WARN("patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
>  			}
> 
> 
> 
> -- 

Hmm, that should already be fixed in the version Andrew Morton has.
Could you test with v0.28 and confirm its already fixed?


  http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-v0.28

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/