lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <49A321BA.2040500@gmail.com>
Date:	Mon, 23 Feb 2009 23:22:50 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Bob Copeland <me@...copeland.com>
CC:	Sitsofe Wheeler <sitsofe@...oo.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	ath5k-devel@...ema.h4ckr.net,
	Nick Kossifidis <mickflemm@...il.com>,
	"Luis R. Rodriguez" <lrodriguez@...eros.com>
Subject: Re: [TIP] BUG kmalloc-4096: Poison overwritten (ath5k_rx_skb_alloc)

On 23.2.2009 16:35, Bob Copeland wrote:
> As I understand it, yes, we don't do the right thing when the more flag
> is set.  We're supposed to keep processing packets until we get one with
> the done flag, and then all of that is supposed to be merged into a single
> packet.  Other flags such as the rx rate are only valid on the final
> packet.

What I don't understand is how we can proceed further, if we should 
never get done flag set according to the specs for the buffer which has 
more flag set. We should hit (unlikely(ret == -EINPROGRESS)) test everytime.

> So I am not sure if the jumbo packets are causing bad things to happen,
> or if they are an indication that something bad has already happened.

I don't know, it was just an idea. I tried to lower rxbufsize to 1000 
and see no problems so far (except unsupported jumbo warnings and packet 
loss indeed).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ