linux-kernel - Re: Re: [Linux-fbdev-devel] [PATCH] fb: hide cursor in graphics mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20090223084511.1CA9A36FDC8@f44.poczta.interia.pl>
Date:	23 Feb 2009 09:45:10 +0100
From:	krzysztof.h1@...zta.fm
To:	Risto Suominen <risto.suominen@...il.com>,
	Krzysztof Helt <krzysztof.h1@...zta.fm>, adaplas@....net,
	Andrew Morton <akpm@...ux-foundation.org>,
	geert@...ux-m68k.org, linux-fbdev-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: Re: [Linux-fbdev-devel] [PATCH] fb: hide cursor in graphics mode

Risto Suominen napisał(a):
> Krzysztof, my patch is basically the same as yours. I already tried
> to send it to Xorg mailing list, but did not receive any feedback.
> 

Right. One should set zero the xoffset also (can be non-zero on some cards).

The Xfbdev is incorrectly designed as it uses settings read from one
console to apply them to another console. It breaks if someone uses two 
graphics  cards and the target console is on a different card then a 
current one.

I have to find out what how the problem above affects a HW cursor.

Regards,
Krzysztof

> If virtual resolution is higher than the screen (as in atyfb), and
> yoffset
> given by the framebuffer driver happens to be non-zero (fbcon changes it
> on-
> the-fly), Xfbdev places its image starting above the displayed part of
> the
> framebuffer. This patch makes sure that the whole picture is visible.
> 
> Signed-off-by: Risto Suominen >Risto.Suominen@...il.com>
> ---
> The testing is done on version 1.1.1 and linux kernel version 2.6.18.
> 
> --- a/hw/kdrive/fbdev/fbdev.c.org       2006-07-05 21:31:39.000000000
> +0300
> +++ b/hw/kdrive/fbdev/fbdev.c   2009-01-18 15:42:06.000000000 +0200
> @@ -215,6 +215,8 @@ fbdevScreenInitialize (KdScreenInfo *scr
> 
>      /* Now get the new screeninfo */
>      ioctl (priv->fd, FBIOGET_VSCREENINFO, >priv->var);
> +    /* We can get anything into yoffset if fbcon is active */
> +    priv->var.yoffset = 0;
>      depth = priv->var.bits_per_pixel;
>      gray = priv->var.grayscale;
> 
> 



----------------------------------------------------------------------
Promocja w Speak Up. Angielski 50% gratis! 
Liczba miejsc ograniczona. Sprawdź!>> http://link.interia.pl/f205c


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/