linux-kernel - Re: Performance regression in write() syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0902232021310.3111@localhost.localdomain>
Date:	Mon, 23 Feb 2009 20:28:54 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Nick Piggin <nickpiggin@...oo.com.au>
cc:	Salman Qazi <sqazi@...gle.com>, davem@...emloft.net,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Andi Kleen <andi@...stfloor.org>
Subject: Re: Performance regression in write() syscall

On Tue, 24 Feb 2009, Nick Piggin wrote:
> 
> What does unixbench's fstime test do? If it is just writing to the
> pagecache, then this would be unexpected.

Hmm. Not necessarily. Even just plain writes may be slowed down, since the 
nontemporal loads and stores are generally slower than the normal case. So 
it does make some kind of sense to try to avoid the noncached versions for 
small writes - because small writes tend to be for temp-files.

I don't know if PAGE_SIZE is the right thing to test, and I also don't 
know if this is necessarily the best place to test it in, but I don't 
think it's necessarily wrong to do something like this.

In fact, I think we might also just check alignment. Doing the nontemporal 
crud makes little sense for a non-8-byte-aligned destination, since it 
will have to do the alignment stores cached anyway - and mixing them 
across a cacheline is just crazy.

(The test program doesn't seem to be testing that particular case)

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/