linux-kernel - [PATCH] acer-wmi: Fix regression in backlight detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1235454078-3069-1-git-send-email-mspang@csclub.uwaterloo.ca>
Date:	Tue, 24 Feb 2009 00:41:18 -0500
From:	Michael Spang <mspang@...lub.uwaterloo.ca>
To:	Carlos Corbacho <carlos@...angeworlds.co.uk>
Cc:	Thomas Renninger <trenn@...e.de>, Andi Kleen <ak@...ux.intel.com>,
	Len Brown <len.brown@...el.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] acer-wmi: Fix regression in backlight detection

Currently we disable the Acer WMI backlight device if there is no ACPI
backlight device. As a result, we end up with no backlight device at
all. We should instead disable it if there is an ACPI device, as the
other laptop drivers do. This regression was introduced in febf2d9.

Signed-off-by: Michael Spang <mspang@...lub.uwaterloo.ca>
---
 drivers/platform/x86/acer-wmi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Each laptop driver with backlight support got a similar change around
febf2d9. The changes to the other drivers look correct; see e.g. a598c82f
for a similar but correct change. The regression is also in 2.6.28.

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 94c9f91..6bcca61 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -1297,7 +1297,7 @@ static int __init acer_wmi_init(void)
 
 	set_quirks();
 
-	if (!acpi_video_backlight_support() && has_cap(ACER_CAP_BRIGHTNESS)) {
+	if (acpi_video_backlight_support() && has_cap(ACER_CAP_BRIGHTNESS)) {
 		interface->capability &= ~ACER_CAP_BRIGHTNESS;
 		printk(ACER_INFO "Brightness must be controlled by "
 		       "generic video driver\n");
-- 
1.6.0.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/