lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <49A3DC56.5010907@kernel.org>
Date:	Tue, 24 Feb 2009 20:39:02 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Johannes Weiner <hannes@...xchg.org>
CC:	mingo@...e.hu, rusty@...tcorp.com.au, tglx@...utronix.de,
	x86@...nel.org, linux-kernel@...r.kernel.org, hpa@...or.com,
	jeremy@...p.org, cpw@....com, nickpiggin@...oo.com.au,
	ink@...assic.park.msu.ru
Subject: Re: [PATCH 02/10] bootmem: clean up arch-specific bootmem wrapping

Hello,

Johannes Weiner wrote:
> This won't suffice as reserve_bootmem() doesn't use
> alloc_bootmem_core(), so now you effectively removed the node-0
> restriction for reserve_bootmem() on this configuration.

Ah... right.  :-(

> I wonder why this setup wants to register several bootmem nodes but
> only use node 0, anyway.  Does someone remember? :)
> 
...
>> -static void * __init alloc_bootmem_core(struct bootmem_data *bdata,
>> +static void * __init __alloc_bootmem_core(struct bootmem_data *bdata,
>>  				unsigned long size, unsigned long align,
>>  				unsigned long goal, unsigned long limit)
> 
> static but you refer to it in arch/x86/include/mmzone_32.h.

Yeah, that's why it's a macro.  I thought about putting it into a
separate header file, say, asm/bootmem-wrapper.h and including it only
from bootmem.c but it looked like an overkill, so...

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ