linux-kernel - Re: [GIT PULL] block bits for 2.6.29-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090224134555.GA21436@infradead.org>
Date:	Tue, 24 Feb 2009 08:45:55 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] block bits for 2.6.29-rc5

On Fri, Feb 20, 2009 at 08:26:35AM +0100, Jens Axboe wrote:
> It seems to work fine for me, tested with a modified sd that doesn't
> have barrier support and loop:
> 
> Filesystem "sdc1": Disabling barriers, trial barrier write failed
> XFS mounting filesystem sdc1
> 
> and
> 
> Filesystem "loop0": Disabling barriers, trial barrier write failed
> XFS mounting filesystem loop0
> 
> No extra failure warnings on the barrier IO itself. What device do you
> see this on?

virtio_blk and loop.  bvut I have investigated this further, and the
reason why I still saw the warnings is that xfs does a
blkdev_issue_flush on unomunt which is not protected by the barrier
flag, so it gets issued unconditionally.  So we got the additional
warning on unmount.  I've sent a patch to make the blkdev_issue_flush
conditionally to fix that issue.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/