linux-kernel - Re: [PATCH 1/2] cs553x-gpio: add AMD CS5535/CS5536 GPIO driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090224120637.18073f93.akpm@linux-foundation.org>
Date:	Tue, 24 Feb 2009 12:06:37 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Andres Salomon <dilinger@...ued.net>
Cc:	linux-kernel@...r.kernel.org, tiwai@...e.de, katzj@...hat.com,
	cjb@...top.org, jayakumar.alsa@...il.com, jordan@...micpenguin.net,
	linux-geode@...ts.infradead.org, perex@...ex.cz,
	David Brownell <david-b@...bell.net>
Subject: Re: [PATCH 1/2] cs553x-gpio: add AMD CS5535/CS5536 GPIO driver
 support

On Fri, 20 Feb 2009 22:12:02 -0500
Andres Salomon <dilinger@...ued.net> wrote:

> 
> This creates a CS5535/CS5536 GPIO driver which uses a gpio_chip backend
> (allowing GPIO users to use the generic GPIO API if desired) while also
> allowing architecture-specific users directly (via the cs553x_gpio_*
> functions).
> 
> Tested on an OLPC machine.  Some Leemotes also use CS5536 (with a mips
> cpu), which is why this is in drivers/gpio rather than arch/x86.  Currently,
> it conflicts with older geode GPIO support; once MFGPT support is reworked
> to also be more generic, the older geode code will be removed.
> 
> +EXPORT_SYMBOL_GPL(cs553x_gpio_set);
> +EXPORT_SYMBOL_GPL(cs553x_gpio_clear);
> +EXPORT_SYMBOL_GPL(cs553x_gpio_isset);

Nothing uses these exports.  In fact these symbols could be made static
to drivers/gpio/cs553x-gpio.c?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/