linux-kernel - Re: [PATCHSET x86/core/percpu] improve the first percpu chunk allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49A46081.9080008@kernel.org>
Date:	Tue, 24 Feb 2009 13:02:57 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Tejun Heo <tj@...nel.org>, rusty@...tcorp.com.au,
	tglx@...utronix.de, x86@...nel.org, linux-kernel@...r.kernel.org,
	hpa@...or.com, jeremy@...p.org, cpw@....com,
	nickpiggin@...oo.com.au, ink@...assic.park.msu.ru
Subject: Re: [PATCHSET x86/core/percpu] improve the first percpu chunk	allocation

Ingo Molnar wrote:
> * Ingo Molnar <mingo@...e.hu> wrote:
> 
>>>   git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git 
>>>   tj-percpu
>> ok, i pulled it into tip:core/percpu (one conflict resolution 
>> done - please double check it), and exposed it to -tip testing 
>> briefly.
>>
>> Six x86 test-systems failed ;-) One of them had this panic:
>>
>> Scan SMP from ffff880000000000 for 1024 bytes.
>> Scan SMP from ffff88000009fc00 for 1024 bytes.
>> Scan SMP from ffff8800000f0000 for 65536 bytes.
>> found SMP MP-table at [ffff8800000fe680] fe680
>> PANIC: early exception 0  rip   :                 error   cr2       
>> PANIC: early exception 0  rip   :                 error   cr2   
> 
> Ah, spoke too soon. Bisection gave this commit from Yinghai:
> 
> dc07da5: x86: check range in reserve_early()
> 

arh...

should be

diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index e858268..b114499 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -858,6 +858,9 @@ void __init reserve_early_overlap_ok(u64 start, u64 end, char *name)
  */
 void __init reserve_early(u64 start, u64 end, char *name)
 {
+	if (start >= end)
+		return;
+
 	drop_overlaps_that_are_ok(start, end);
 	__reserve_early(start, end, name, 0);
 }




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/