linux-kernel - Re: [PATCH 0/4][RFC] event tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49A473ED.4010001@redhat.com>
Date:	Tue, 24 Feb 2009 17:25:49 -0500
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Theodore Tso <tytso@....edu>,
	Arjan van de Ven <arjan@...radead.org>,
	Pekka Paalanen <pq@....fi>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Jason Baron <jbaron@...hat.com>,
	Martin Bligh <mbligh@...gle.com>,
	Mathieu Desnoyers <compudj@...stal.dyndns.org>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Jens Axboe <jens.axboe@...cle.com>
Subject: Re: [PATCH 0/4][RFC] event tracer

Steven Rostedt wrote:
> On Tue, 24 Feb 2009, Peter Zijlstra wrote:
> 
>> On Tue, 2009-02-24 at 14:33 -0500, Steven Rostedt wrote:
>>
>>>  DECLARE_TRACE_FMT(sched_kthread_stop,
>>>         TPPROTO(struct task_struct *t),
>>>                   TPARGS(t),
>>>                    "task %s:%d", TPARGS(t->comm, t->pid));
>> Consistency would require something like:
>>
>> DECLARE_TRACE_FMT(sched_kthread_stop,
>> 		  TPPROTO(struct task_struct *t),
>> 		  TPARGS(t),
>> 		  TPFMT("task %s:%d", t->comm, t->pid));
>>
>> I seem to remember Jason proposing something like this in the past.
> 
> Hmm, I'll have to look at that. (althought I was going to use a different 
> TPARGS for the format args.)
> 
> I have, for now:
> 
> 	event_printk("(%s)" fmt "\n", #call, fmtargs);
> 
> I guess I can redefine the TPFMT too.
> 
> #undef TPFMT
> #define TPFMT(fmt, args...) \
> 	"(%s)" fmt "\n", #call, ##args
> 
> and then I could do
> 
> 	event_printk(fmt);

Why don't you do as below? :)
	event_printk_line("(" #call ")" ##fmtandargs);

Anyway, your proposal is good for me, because it will recover
an information which tracepoint has lost.

Thank you!

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/