linux-kernel - Re: [patch 1/2] slub: move min_partial to struct kmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 25 Feb 2009 09:17:46 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Christoph Lameter <cl@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 1/2] slub: move min_partial to struct kmem_cach

On Mon, 23 Feb 2009, Christoph Lameter wrote:
> > > The second patch in this series as a /sys/kernel/slab/cache/min_partial
> > > tunable that uses calculate_min_partial() to enforce a sane range, so
> > > while it may not actually be doing any calculations, the ilog2() is
> > > appropriately placed in kmem_cache_open().  We don't want to be taking the
> > > log of the user's min_partial value.
> > 
> > Then Rename the function to set_min_partial()?

On Mon, 2009-02-23 at 08:37 -0800, David Rientjes wrote:
> I don't have any strong opinions as to the specific name, so I'll leave 
> this up to Pekka.  set_min_partial(), to me, seems to indicate that 
> s->min_partial will unconditionally set to the value passed, which isn't 
> necessarily true.

Applied, thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/