linux-kernel - Re: [patch][rfc] fs: move bdev code out of buffer.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Feb 2009 11:53:38 +0100
From:	Nick Piggin <npiggin@...e.de>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	linux-fsdevel@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Jens Axboe <jens.axboe@...cle.com>
Subject: Re: [patch][rfc] fs: move bdev code out of buffer.c

On Wed, Feb 25, 2009 at 05:35:43AM -0500, Jeff Garzik wrote:
> Nick Piggin wrote:
> >Move some block device related code out from buffer.c and put it in
> >block_dev.c. I'm trying to move non-buffer_head code out of buffer.c
> >
> >Is this OK?
> >
> >---
> > fs/block_dev.c              |  146 
> > ++++++++++++++++++++++++++++++++++++++++++++
> > fs/buffer.c                 |  145 
> > -------------------------------------------
> > include/linux/buffer_head.h |    7 --
> > include/linux/fs.h          |    7 ++
> > 4 files changed, 153 insertions(+), 152 deletions(-)
> 
> If you are going to churn all this old code, maybe the blkdev stuff 
> better belongs in block/ dir?

If you have a look at it, it's all dealing with buffercache and
filesystem metadata I think. So I think fs/block_dev.c is the
right place for it.

block/ shouldn't know about filesystems or pagecache.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/