linux-kernel - Re: [PATCH v2 2/4] x86: Add an option to compile with -ffunction-sections -fdata-sections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49A49D2B.8050701@zytor.com>
Date:	Tue, 24 Feb 2009 17:21:47 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Tim Abbott <tabbott@....EDU>
CC:	linux-kernel@...r.kernel.org, Anders Kaseorg <andersk@....EDU>,
	Jeff Arnold <jbarnold@....EDU>, Waseem Daher <wdaher@....EDU>,
	Denys Vlasenko <vda.linux@...glemail.com>,
	Nikanth Karthikesan <knikanth@...e.de>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH v2 2/4] x86: Add an option to compile with -ffunction-sections
 -fdata-sections

Tim Abbott wrote:
> From: Waseem Daher <wdaher@....edu>
> 
> This patch makes it possible to link and boot an x86 kernel with
> -ffunction-sections and -fdata-sections enabled.
> 
> Modpost currently warns whenever it sees a section with a name
> matching [.][0-9]+$ because they are often caused by section flag
> mismatch errors.  When compiling with -ffunction-sections
> -fdata-sections, gcc places various classes of local symbols in
> sections with names such as .rodata.__func__.12345, causing these
> warnings to be printed spuriously.  The simplest fix is to disable the
> warning when CONFIG_FUNCTION_DATA_SECTIONS is enabled.
> 

This is a pretty critical set of warnings, that often represent real
bugs.  I don't think it's acceptable to lose them.  However, you already
have (prior in the sequence) changed those section names to not conflict
with the automatically generated ones, so it seems to me that this
should be fixable without too much pain.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/