linux-kernel - Re: [PATCHSET x86/core/percpu] improve the first percpu chunk allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49A4ABAC.90602@kernel.org>
Date:	Wed, 25 Feb 2009 11:23:40 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Yinghai Lu <yinghai@...nel.org>, rusty@...tcorp.com.au,
	tglx@...utronix.de, x86@...nel.org, linux-kernel@...r.kernel.org,
	hpa@...or.com, jeremy@...p.org, cpw@....com,
	nickpiggin@...oo.com.au, ink@...assic.park.msu.ru
Subject: Re: [PATCHSET x86/core/percpu] improve the first percpu chunk	allocation

Hello, Ingo.

Patches posted to fix the build failure and warning.  Patches are also
available in the usual git tree.

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git tj-percpu

Ingo Molnar wrote:
> and one tip:master merge impact due to API change:
> 
>  kernel/trace/trace_functions_graph.c: In function ‘graph_trace_close’:
>  kernel/trace/trace_functions_graph.c:836: error: implicit declaration of function ‘percpu_free’
> 
> that's free_percpu() now, right?
> 
> Btw., why was this rename done? We generally standardize on 
> hierarchical names, going from the more general to the more 
> specific names, left to right. So we have 
> <subsystem>_<functionality>_<subtype> sort of names generally.

It's a strange story and not really a rename.

We had __percpu_alloc_mask(), percpu_alloc(), __alloc_percpu() and
alloc_percpu() and of course matching frees.  The percpu_*() stuff was
introduced so that allocations can take online cpus into
consideration.  So, percpu_alloc() uses cpu_online_map as the default
allocation mask while alloc_percpu() uses cpu_possible_map.  The
allocation mask thing never really took off and there virtually was no
user and got killed.

If the only merge impact was percpu_free() and it's not missing
percpu_alloc(), it could be that allocation path used alloc_percpu()
but free path used percpu_free().

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/