linux-kernel - Re: [PATCH 1/4] tracing: add DEFINE_TRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Feb 2009 11:28:59 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Mathieu Desnoyers <compudj@...stal.dyndns.org>
cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Theodore Tso <tytso@....edu>,
	Arjan van de Ven <arjan@...radead.org>,
	Pekka Paalanen <pq@....fi>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Jason Baron <jbaron@...hat.com>,
	Martin Bligh <mbligh@...gle.com>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Jens Axboe <jens.axboe@...cle.com>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 1/4] tracing: add DEFINE_TRACE_FMT to tracepoint.h


On Wed, 25 Feb 2009, Mathieu Desnoyers wrote:

> * Steven Rostedt (rostedt@...dmis.org) wrote:
> > From: Steven Rostedt <srostedt@...hat.com>
> > 
> > This patch creates a DEFINE_TRACE_FMT to map to DECLARE_TRACE.
> > This allows for the developers to place format strings and
> > args in with their tracepoint declaration. A tracer may now
> > override the DEFINE_TRACE_FMT macro and use it to record
> > a default format.
> > 
> 
> Hi Steven,
> 
> How comes does a DEFINE_* maps to a DECLARE_* ?
> 
> Usually, DEFINE_* are meant to be put in .c files. DECLARE_* are in
> headers. I don't see how the mapping you propose here can be
> semantically correct ?

Because it can be either a define or a declare ;-)

Gag, I can't win! First Andrew points out that I use DECLARE_TRACE_FMT 
when it should be a DEFINE. Now I go change it and you state that it 
should be a DECLARE not a DEFINE!


Well, any tracer that remaps it, it should be a DEFINE. Just in the 
"default" case of trace points, is it used as a DECLARE. Because, it 
ignores the fmt parameter that would be used in the define.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/