linux-kernel - Re: [PATCH RESEND] sched_rt: don't start timer when rt bandwidth disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1235587301.4645.3786.camel@laptop>
Date:	Wed, 25 Feb 2009 19:41:41 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] sched_rt: don't start timer when rt bandwidth
 disabled

Right, thanks for the reminder.

On Wed, 2009-02-25 at 09:59 -0800, Hiroshi Shimamoto wrote:
> From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
> 
> Impact: fix incorrect condition check
> 
> No need to start rt bandwidth timer when rt bandwidth is disabled.
> If this timer starts, it may stop at sched_rt_period_timer() on the first time.
> 
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>

Yep, looks like a good catch, thanks!

> ---
>  kernel/sched.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 4484f9c..9e49ac8 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -223,7 +223,7 @@ static void start_rt_bandwidth(struct rt_bandwidth *rt_b)
>  {
>  	ktime_t now;
>  
> -	if (rt_bandwidth_enabled() && rt_b->rt_runtime == RUNTIME_INF)
> +	if (!rt_bandwidth_enabled() || rt_b->rt_runtime == RUNTIME_INF)
>  		return;
>  
>  	if (hrtimer_active(&rt_b->rt_period_timer))

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/