linux-kernel - Re: [PATCH v2] bonding: move IPv6 support into a separate kernel module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28797.1235599858@death.nxdomain.ibm.com>
Date:	Wed, 25 Feb 2009 14:10:58 -0800
From:	Jay Vosburgh <fubar@...ibm.com>
To:	Brian Haley <brian.haley@...com>
cc:	David Miller <davem@...emloft.net>,
	Andrey Borzenkov <arvidjaar@...l.ru>,
	Vladislav Yasevich <vladislav.yasevich@...com>,
	Chuck Lever <chuck.lever@...cle.com>,
	Theodore Tso <tytso@....edu>, Valdis.Kletnieks@...edu,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	bonding-devel@...ts.sourceforge.net,
	"J.A. Magallón" 
	<jamagallon@....com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] bonding: move IPv6 support into a separate kernel module

Brian Haley <brian.haley@...com> wrote:
[...]
>This patch moves the IPv6 bonding code into a separate kernel module
>called bonding_ipv6 if either bonding or IPv6 are built as modules.
>If both are built into the kernel then this is as well.  Bonding_ipv6.ko
>registers an "send_unsol_na" function pointer for the unsolicited
>advertisement function to be called on a failover - the default action
>is to do nothing.  The notifier callbacks are now registered in this
>module and not in the base bonding module.
>
>Also, have the IPv6 address notifier request that the bonding_ipv6
>module be loaded when an IFF_MASTER device is first brought-up.
>This avoids users from having to do this explicitly with modprobe.

	I'm not entirely sure what the right solution for all of this
is, but it doesn't seem to me that cranking on bonding and adding a
special case to ipv6 is the best way to go.

	This patch won't resolve the reported similar (but presumably
lower profile) issues with SCTP or qeth, and it seems unlikely that this
is the last time some driver will gain a run time dependence on ipv6
after being compiled with CONFIG_IPV6.

Theodore Tso <tytso@....edu> wrote (in a different thread):
>I think I can pretty much guarantee that distro users will be
>clamoring for a quick and easy way to block ipv6, and it's in our
>interest to document the recomended way to block it that doesn't cause
>weird problems with bonding, etc.

	I agree with this.  

	I've been fooling with the disable_ipv6 sysctl, and one issue is
that, at least on the distro I'm testing on (SLES), it's not picked up
from /etc/sysctl.conf at boot time (presumably because ipv6 isn't loaded
yet, although I haven't really checked).


	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/