linux-kernel - Re: [PATCH 14/15] bitops: Change the bitmap index from int to unsigned long [frv]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7355.1235605851@redhat.com>
Date:	Wed, 25 Feb 2009 23:50:51 +0000
From:	David Howells <dhowells@...hat.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	dhowells@...hat.com, Justin Chen <jchen@...st41.cup.hp.com>,
	linux-arch@...r.kernel.org, bjorn.helgaas@...com,
	justin.chen@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/15] bitops: Change the bitmap index from int to unsigned long [frv]

H. Peter Anvin <hpa@...or.com> wrote:

> What makes you say that, in particular?

I prefer it.  Actually, I'd prefer it all to be on one line, but some people
get picky about the 80 char limit.

Besides, that "static inline" is merely a qualifier to the declaration of the
function.  The return type, name and args are part of the declaration of the
function and belong together more.

> A casual grep finds no less than 3524 instances of "static inline <type>" --
> presumably with a function name following -- and only 447 instances of
> "static inline" without a type in the kernel.

But how does it break down between "static inline type\nfunction_name" and
"static inline\ntype function_name"?  That's more to the point.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/