linux-kernel - Re: [PATCH] pcie_portdriver: FIX: pcie_port_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m1k57ftaaz.fsf@fess.ebiederm.org>
Date:	Tue, 24 Feb 2009 20:22:44 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pcie_portdriver: FIX: pcie_port_device_remove (take 2)

Jesse Barnes <jbarnes@...tuousgeek.org> writes:

> On Friday, February 20, 2009 8:16:07 pm Eric W. Biederman wrote:
>> pcie_port_device_remove currently calls the remove method of port
>> drivers twice.  Ouch!
>>
>> We are calling device_for_each_child multiple times for no apparent
>> reason.
>>
>> So make it simple. Place put_device and device_unregister into
>> remove_iter, and throw out the rest.  Only call device_for_each_child
>> once.
>>
>> The code is simpler and actually works!
>>
>> Changelog:
>> v2 rebase against the linux-next tree so I don't conflict with Rafael's
>>    irq work, and remove the irq handling cleanups as Rafael's patch already
>>    made them.
>
> Thanks for rebasing; it's queued up in my linux-next branch now.  If we really 
> need this in the stable kernel it'll be a bit painful, since some of these 
> structures have changed around a bit...

I don't think it is necessary for stable.  The pciehp still needs more
work, and if anyone of the other port drivers was being hotplugged I
expect someone would have noticed the bug and fixed it before now.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/