linux-kernel - Re: [PATCH] fix duplicate include in emu10k1.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hzlg9in7m.wl%tiwai@suse.de>
Date:	Thu, 26 Feb 2009 10:03:57 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	hpa@...or.com, mingo@...hat.com, dwmw2@...radead.org,
	acme@...stprotocols.net, airlied@...ux.ie, perex@...ex.cz,
	yoshfuji@...ux-ipv6.org, mchehab@...hat.com, tglx@...utronix.de,
	hpa@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix duplicate include in emu10k1.h

At Thu, 26 Feb 2009 09:57:27 +0100,
Arnd Bergmann wrote:
> 
> The earlier patch 'make most exported headers use strict integer types'
> accidentally includes <types.h> both from the common and from the
> kernel-only parts.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

To both patches (better merged, though),
Acked-by: Takashi Iwai <tiwai@...e.de>


Thanks!

Takashi
> 
> ---
> On Thursday 26 February 2009, you wrote:
> 
> > > @@ -34,6 +36,8 @@
> > >  #include <sound/timer.h>
> > >  #include <linux/interrupt.h>
> > >  #include <linux/mutex.h>
> > > +#include <linux/types.h>
> > > +
> > 
> > Isn't the second inclusion superfluous?
> > 
> Yes, I must have introduced the second one first, but in the
> wrong section (kernel only), and then didn't notice it when
> introducing it again to fix headers_check.
> 
> --- a/include/sound/emu10k1.h
> +++ b/include/sound/emu10k1.h
> @@ -36,7 +36,6 @@
>  #include <sound/timer.h>
>  #include <linux/interrupt.h>
>  #include <linux/mutex.h>
> -#include <linux/types.h>
>  
>  #include <asm/io.h>
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/