linux-kernel - Re: [tip:core/header-fixes] compiler-gcc4: conditionalize #error on __KERNEL_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 26 Feb 2009 01:21:18 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	hpa@...or.com, mingo@...hat.com, tglx@...utronix.de,
	hpa@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [tip:core/header-fixes] compiler-gcc4: conditionalize #error on __KERNEL__

On Thursday 26 February 2009, H. Peter Anvin wrote:
> compiler-gcc4: conditionalize #error on __KERNEL__
> 
> Impact: Fix for exported headers
> 
> We only want to error out on specific gcc versions if we are actually
> building the kernel, so conditionalize the #if...#error on __KERNEL__.
> 
> Based on a patchset by Arnd Bergmann <arnd@...db.de>.
> 
> Cc: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: H. Peter Anvin <hpa@...ux.intel.com>

No kidding. It never occurred to me that this hunk from my patch was
any good. It just happened that I was cross compiling for powerpc
and only had a ppc64-gcc-4.1.0 installed on my laptop, so I commented
out that line with the intention of reverting that change after a
successful build...

Good catch!

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/