linux-kernel - Re: [PATCH v2 0/5] [RFC] copy_strtok_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0902260900350.26792@gandalf.stny.rr.com>
Date:	Thu, 26 Feb 2009 09:04:58 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v2 0/5] [RFC] copy_strtok_from_user


On Thu, 26 Feb 2009, Steven Rostedt wrote:

> 
> On Thu, 26 Feb 2009, Ingo Molnar wrote:
> > > 
> > > yes. Note that strsep() is the preferred API. (in fact it's 
> > > the only such string API that is in the kernel)
> > 
> > btw., for larger strings we cannot really copy into the kernel i 
> > suspect. We'd have to kmalloc() and that adds overhead, etc.
> > 
> > Nevertheless, copy_strsep_from_user() would be the symmetric API 
> > here.
> 
> OK, I'll rebase again calling it copy_strsep_from_user. And I'll change 
> the implementation to use copy_from_user/strsep

I need to have my first cup of coffee _before_ replying :-p

My first understanding of strsep was correct.  strsep stops at the first 
delimiter. It may be time to add strtok_r into the kernel.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/