linux-kernel - Re: [PATCH 5/6] [-mm] epoll: clean up ep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0902260830380.31638@alien.or.mcafeemobile.com>
Date:	Thu, 26 Feb 2009 08:31:34 -0800 (PST)
From:	Davide Libenzi <davidel@...ilserver.org>
To:	Tony Battersby <tonyb@...ernetics.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Jonathan Corbet <corbet@....net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/6] [-mm] epoll: clean up ep_modify

On Tue, 24 Feb 2009, Tony Battersby wrote:

> ep_modify() doesn't need to set event.data from within the ep->lock
> spinlock as the comment suggests.  The only place event.data is used
> is ep_send_events_proc(), and this is protected by ep->mtx instead
> of ep->lock.  Also update the comment for mutex_lock() at the top
> of ep_scan_ready_list(), which mentions epoll_ctl(EPOLL_CTL_DEL)
> but not epoll_ctl(EPOLL_CTL_MOD).
> 
> ep_modify() can also use spin_lock_irq() instead of
> spin_lock_irqsave().

Pre-mtx stuff.

Acked-by: Davide Libenzi <davidel@...ilserver.org>


- Davide


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/