linux-kernel - Re: [patch 5/7] make netfilter use strict integer types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090225.165552.32040707.davem@davemloft.net>
Date:	Wed, 25 Feb 2009 16:55:52 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jengelh@...ozas.de
Cc:	arnd@...db.de, hpa@...or.com, sam@...nborg.org, kyle@...radead.org,
	mingo@...e.hu, jaswinderrajput@...il.com, mingo@...hat.com,
	dwmw2@...radead.org, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org
Subject: Re: [patch 5/7] make netfilter use strict integer types

From: Jan Engelhardt <jengelh@...ozas.de>
Date: Thu, 26 Feb 2009 01:10:25 +0100 (CET)

> 
> On Thursday 2009-02-26 00:51, arnd@...db.de wrote:
> 
> >Netfilter traditionally uses BSD integer types in its
> >interface headers. This changes it to use the Linux
> >strict integer types, like everyone else.
> 
> I _strongly disagree_ with this move. Userspace also has the uintX
> types via <stdint.h>/<cstdint>, and now you are adding a dependency
> on linux/types.h, not to mention that your step can lead to compile
> time piling up.
> 
> IMHO, __uXX should be replaced by uintX_t, but a move this great I
> will leave to future generations because there is just too much
> persisting opinions wrt. such proposal. As such I'd like to join
> and persist on my position and that uintX that we have should be kept.

Disagreed, I think we should have done what Arnd is doing
a long time ago.

Ending up with linux/types.h in userspace for these kinds of
interfaces is already a fore-gone conclusion, it happens
already whether you like it or not.

And existing apps will work just fine, since they are already
getting stdint.h

As for compile time, since you're already getting linux/types.h
in your apps it's a non-argument.  But even if it was, what
are you compiling netfilter utilities on?  A VAX?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/