linux-kernel - Re: [Staging/p9auth] Feb 26 Next: build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090226173531.GB23465@kroah.com>
Date:	Thu, 26 Feb 2009 09:35:31 -0800
From:	Greg KH <greg@...ah.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	"Sachin P. Sant" <sachinp@...ibm.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	ashwin.ganti@...il.com
Subject: Re: [Staging/p9auth] Feb 26 Next: build failure

On Thu, Feb 26, 2009 at 08:59:32AM -0800, Randy Dunlap wrote:
> Greg KH wrote:
> > On Thu, Feb 26, 2009 at 04:40:10PM +0530, Sachin P. Sant wrote:
> >> Feb 26 Next tree randconfig build fails with
> >>
> >> drivers/staging/p9auth/p9auth.c: In function cap_write:
> >> drivers/staging/p9auth/p9auth.c:249: error: implicit declaration of 
> >> function current_uid
> >> drivers/staging/p9auth/p9auth.c:261: error: implicit declaration of 
> >> function prepare_creds
> >> drivers/staging/p9auth/p9auth.c:261: warning: assignment makes pointer from 
> >> integer without a cast
> >> drivers/staging/p9auth/p9auth.c:266: error: dereferencing pointer to 
> >> incomplete type
> >> drivers/staging/p9auth/p9auth.c:267: error: dereferencing pointer to 
> >> incomplete type
> >> drivers/staging/p9auth/p9auth.c:268: error: implicit declaration of 
> >> function commit_creds
> >> make[3]: *** [drivers/staging/p9auth/p9auth.o] Error 1
> > 
> > Wierd, I thought cred.h would be pulled in with the current include
> > files.
> 
> Even if it were, that's not what we want.  We want explicit #includes
> for macros or structs etc. that are used in a source file.

I agree, sorry, I didn't mean to assume otherwise.

> > With this .config, if you add:
> > 	#include <linux/cred.h>
> > to drivers/staging/p9auth/p9auth.c does it solve the build error?
> > 
> > I'll go add it just to be safe :)
> 
> It needs both cred.h and sched.h in my testing.

Ok, I'll go add both.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/