linux-kernel - Re: [PATCH 3/4 v9] i.MX31: framebuffer driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9c3a7c20902261041t7e483c24m1151b89d79b5f718@mail.gmail.com>
Date:	Thu, 26 Feb 2009 11:41:27 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	Sascha Hauer <s.hauer@...gutronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4 v9] i.MX31: framebuffer driver

On Thu, Feb 26, 2009 at 12:37 AM, Guennadi Liakhovetski
<g.liakhovetski@....de> wrote:
> On Wed, 25 Feb 2009, Dan Williams wrote:
>
>> On Thu, Feb 19, 2009 at 11:36 AM, Dan Williams <dan.j.williams@...el.com> wrote:
>> > On Thu, 2009-02-19 at 07:41 -0700, Guennadi Liakhovetski wrote:
>> >> Please, oh, please, wake me up if I'm dreaming... In the patch below all
>> >> the indentation in _both_ mx3fb.h and mx3fb.c is with TABs (ok, didn't
>> >> check all, a couple). Nun im Linus' git-tree - _ALL_ (that I checked)
>> >> indentation is with... BLANKS!!!??? Could someone, please, tell me what
>> >> was in that cup of tee I've drunk an hour ago?... Dan, you pushed this
>> >> patch via your tree, right? Could you double-check, please?
>> >>
>> >
>> > What a mess.  The other patches in your series were applied and
>> > checkpatched from the tarball you sent.  This last fix up patch was not
>> > cc'd to lkml so I fell back to applying it from a saved Thunderbird
>> > message.  The real issue is that I did not have checkpatch automated
>> > from StackedGIT's import command.  Please double check the fix below...
>> >
>>
>> Sascha,
>>
>> Will you be taking this clean-up through your tree?  I don't think it
>> is suitable for 2.6.29 and in my opinion it belongs with other IMX
>> platform driver fixups targeted for 2.6.30.
>
> __NO__. Please don't. Dan, can you please get my original patch somehow in
> its _original_ form - with TABs and spaces as they were? Please, fix your
> mailer or get another one. In this patch you fixed all spaces at the
> beginning of lines, but not indentation inside lines. E.g.
>
> -#define MX3FB_NAME             "mx3_sdc_fb"
> +#define MX3FB_NAME             "mx3_sdc_fb"
>
> the first line (with spaces) is after applying this your patch to the
> current tree, the below line (with TABs) is my original version. Please,
> fix!
>

Like I said earlier, because this was not cc'd to lkml I do not have
access to the original with a sane mail system.  I actually think the
incoming Exchange server may have done the tabs to spaces conversion
[1] because even retrieving the message with mutt over imap has
issues.  Please resend v9 and cc lkml, then I will do a
revert/reapply.

--
Dan

[1]: http://support.microsoft.com/kb/945870
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/