linux-kernel - Re: [PATCH 2/2] mfd: Use the value of the final spin when reading the AUXADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090226142516.fdef29b5.akpm@linux-foundation.org>
Date:	Thu, 26 Feb 2009 14:25:16 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	sameo@...nedhand.com, linux-kernel@...r.kernel.org,
	broonie@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 2/2] mfd: Use the value of the final spin when reading
 the AUXADC

On Wed, 25 Feb 2009 16:23:35 +0000
Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:

> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
>  drivers/mfd/wm8350-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
> index a285cc0..c2be308 100644
> --- a/drivers/mfd/wm8350-core.c
> +++ b/drivers/mfd/wm8350-core.c
> @@ -1111,7 +1111,7 @@ int wm8350_read_auxadc(struct wm8350 *wm8350, int channel, int scale, int vref)
>  	do {
>  		schedule_timeout_interruptible(1);
>  		reg = wm8350_reg_read(wm8350, WM8350_DIGITISER_CONTROL_1);
> -	} while (--tries && (reg & WM8350_AUXADC_POLL));
> +	} while ((reg & WM8350_AUXADC_POLL) && --tries);
>  
>  	if (!tries)
>  		dev_err(wm8350->dev, "adc chn %d read timeout\n", channel);

Please do not ever send any unchangelogged patches ever again, at all, ever.

OK?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/