linux-kernel - Re: [PATCH 1/4] uaccess: add copy_word_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Feb 2009 18:13:47 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
CC:	Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 1/4] uaccess: add copy_word_from_user

Frederic Weisbecker wrote:
> On Wed, Feb 25, 2009 at 06:02:07PM -0800, H. Peter Anvin wrote:
>> Steven Rostedt wrote:
>>> This patch creates a copy_word_from_user function that can copy
>>> a space delimited word from user space. This puts the code in
>>> a new lib/uaccess.c file. This keeps the code in a single location
>>> and may be optimized in the future.
>> I have a bit of an issue with the naming... at least *I* read this as  
>> copying a machine word, which made me wonder why you didn't just use  
>> "get_user".  I would suggest copy_token_from_user or something like that.
>>
>> 	-hpa
> 
> That was the first impression I had too (the sense of a machine word).
> But token seems to me imprecise as well, too much generic.
> 
> Well, since it is well commented, I guess it's not so much an issue...
> 

Well, "word" has the problem that someone looking at a call site is 
likely to get the wrong idea.  "token" may make them confused, but that 
means they'll try to look it up.  However, I'm sure we could do better.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/