linux-kernel - Re: [PATCH] pci: don't enable too many HT MSI mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200902270752.44078.prakash@punnoor.de>
Date:	Fri, 27 Feb 2009 07:52:43 +0100
From:	Prakash Punnoor <prakash@...noor.de>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Robert Hancock <hancockrwd@...il.com>, david@...g.hm,
	Matthew Wilcox <matthew@....cx>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH] pci: don't enable too many HT MSI mapping

On Dienstag 24 Februar 2009 18:37:35 Jesse Barnes wrote:
> On Monday, February 23, 2009 11:51:59 am Yinghai Lu wrote:
> > Impact: fix bug
> >
> > Prakash reported that his c51-mcp51 system ondie sound card doesn't work
> > MSI but if he hack out the HT-MSI on mcp51, the MSI will work well with
> > sound card.
> >
> > this patch rework the nv_msi_ht_cap_quirk()
> > and will only enable ht_msi on own root device and try to avoid to enable
> > ht_msi on device following that root dev
> >
> > Reported-by: Prakash Punnoor <prakash@...noor.de>
> > Tested-by: Prakash Punnoor <prakash@...noor.de>
> > Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>
> Thanks Yinghai & Prakash, applied this fix to my for-linus branch.

I am very sorry, but I made a mistake testing this patch. I messed up my 
kernels and got a false positive and only noticed this now. The patch does NOT 
work and even makes things worse:

dmesg|grep HT
pci 0000:00:09.0: Found disabled HT MSI Mapping
pci 0000:00:09.0: Enabling HT MSI Mapping
pci 0000:00:09.0: Found enabled HT MSI Mapping
pci 0000:00:09.0: Found enabled HT MSI Mapping
pci 0000:00:09.0: Found enabled HT MSI Mapping
pci 0000:00:09.0: Found enabled HT MSI Mapping

This is exactly the device which shouldn't be MSI enabled for me. On the other 
hand, it doesn't enable the needed devices anymore.

So please drop this patch.

Regards,

Prakash
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/