[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <49A7A845.2030709@evidence.eu.com>
Date: Fri, 27 Feb 2009 09:45:57 +0100
From: Claudio Scordino <claudio@...dence.eu.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: alan@...rguk.ukuu.org.uk, alan@...hat.com,
hinko.kocevar@...rtapot.si, janez.cufer@...rtapot.si,
starvik@...s.com, jesper.nilsson@...s.com, apw@...onical.com,
linux-kernel@...r.kernel.org, dev-etrax@...s.com
Subject: Re: [PATCH] Cleanup patch for RS485 on Cris architecture
Andrew Morton ha scritto:
> On Wed, 25 Feb 2009 11:07:52 +0100
> Claudio Scordino <claudio@...dence.eu.com> wrote:
>
>> Dear Alan, dear Andrew,
>>
>> around one month ago I submitted a cleanup patch to use the new
>> general RS485 Linux data structure (introduced by Alan with commit
>> number c26c56c0f40e200e61d1390629c806f6adaffbcc) in the Cris
>> architecture too (currently, Cris still uses the old private data
>> structure instead of the new one).
>>
>> The code compiled, but I couldn't test it at that time.
>>
>> Now, the code has been tested by Hinko Kocevar and Janez Cufer
>> (CC:-ed) from the AXIS group, who also fixed a bug.
>>
>> Therefore, can you please commit the patch in attachment ?
>>
>> Many thanks,
>>
>> Claudio Scordino
>>
>>
>> [0001-RS485-support-on-Cris-rewritten-in-order-to-use-new.patch text/x-diff (9.9KB)]
>> >From 9d4397feff9773820e158693aa73621c0c20f017 Mon Sep 17 00:00:00 2001
>> From: Claudio Scordino <claudio@...dence.eu.com>
>> Date: Tue, 24 Feb 2009 18:00:44 +0100
>> Subject: [PATCH 1/1] RS485 support on Cris rewritten in order to use new serial_rs485 data structure
>>
>>
>> Signed-off-by: Claudio Scordino <claudio@...dence.eu.com>
>> Tested-by: Hinko Kocevar <hinko.kocevar@...rtapot.si>
>> Tested-by: Janez Cufer <janez.cufer@...rtapot.si>
>
> The patch had no changelog - please always provide one.
Sorry, my apologies... Next time I'll keep in mind!
>
> I scraped some text from your covering comment and made this:
>
> Use the new general RS485 Linux data structure (introduced by
> Alan with commit number c26c56c0f40e200e61d1390629c806f6adaffbcc)
> in the Cris architecture too (currently, Cris still uses the old
> private data structure instead of the new one).
>
> for a changelog. Feel free to send better text if that is inappropriate
> or incomplete.
This changelog is perfect.
Many thanks,
Claudio
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists