linux-kernel - Re: [PATCH] net headers: export dcbnl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090227.024635.51509388.davem@davemloft.net>
Date:	Fri, 27 Feb 2009 02:46:35 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sam@...nborg.org
Cc:	christopher.leech@...el.com, linux-netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net headers: export dcbnl.h

From: Sam Ravnborg <sam@...nborg.org>
Date: Fri, 27 Feb 2009 06:55:06 +0100

> On Thu, Feb 26, 2009 at 04:46:35PM -0800, Chris Leech wrote:
> > The DCB netlink interface is required for building the userspace tools
> > available at e1000.sourceforge.net
> 
> Hmmm, is that file ready for export....
> 
> >From dcbnl.h:
> #ifndef __LINUX_DCBNL_H__
> #define __LINUX_DCBNL_H__
> 
> #define DCB_PROTO_VERSION 1
> 
> struct dcbmsg {
>         unsigned char      dcb_family;
>         __u8               cmd;
>         __u16              dcb_pad;
> };
> 
> 1) It uses __u8/__u16 so it would be nice it is included <linux/types.h>
> so these are actually defined.
> 2) Why does it use "unsigned char" for one member and __u8 for another.
> It looks inconsistent.
> 
> We export headers that are much worse but we better raise the bar a little.

Agreed, we should sort out these issues before exporting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/