linux-kernel - Re: [PATCH] modpost: Check the section flags, not name, to catch missing "ax"/"aw"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49A7DE0D.5090205@zytor.com>
Date:	Fri, 27 Feb 2009 04:35:25 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Anders Kaseorg <andersk@....EDU>
CC:	Tim Abbott <tabbott@....EDU>, linux-kernel@...r.kernel.org,
	Jeff Arnold <jbarnold@....EDU>, Waseem Daher <wdaher@....EDU>,
	Denys Vlasenko <vda.linux@...glemail.com>,
	Nikanth Karthikesan <knikanth@...e.de>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH] modpost: Check the section flags, not name, to catch
 missing "ax"/"aw"

Anders Kaseorg wrote:
> On Tue, 24 Feb 2009, H. Peter Anvin wrote:
>> This is a pretty critical set of warnings, that often represent real 
>> bugs.  I don't think it's acceptable to lose them.  However, you already 
>> have (prior in the sequence) changed those section names to not conflict 
>> with the automatically generated ones, so it seems to me that this 
>> should be fixable without too much pain.
> 
> Actually, the problem arises from a conflict between two classes of 
> automatically generated section names, one from ld, and one from gcc.  
> Instead of basing the warning on section names (the existing heuristic 
> also fails to warn on some cases where it should, as it turns out), what 
> do you think about this patch?  I've tested that it still triggers the 
> warning when an "ax" or "aw" is incorrectly removed, and it should handle 
> even more cases than before.
> 

Seems reasonable to me.

	-hpa


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/