| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <154e089b0902261702r52432481q6a0561de9576ed71@mail.gmail.com>
Date: Fri, 27 Feb 2009 02:02:25 +0100
From: Hannes Eder <hannes@...neseder.net>
To: trivial@...nel.org, Artem Bityutskiy <Artem.Bityutskiy@...ia.com>
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/16] MTD: tests: fix sparse warnings: Using plain
integer as NULL pointer
[Added To]
On Sun, Feb 22, 2009 at 1:02 AM, Hannes Eder <hannes@...neseder.net> wrote:
> Fix this sparse warnings:
> drivers/mtd/tests/mtd_oobtest.c:139:33: warning: Using plain integer as NULL pointer
> drivers/mtd/tests/mtd_oobtest.c:192:33: warning: Using plain integer as NULL pointer
> drivers/mtd/tests/mtd_oobtest.c:219:41: warning: Using plain integer as NULL pointer
> drivers/mtd/tests/mtd_oobtest.c:284:25: warning: Using plain integer as NULL pointer
> drivers/mtd/tests/mtd_oobtest.c:525:25: warning: Using plain integer as NULL pointer
> drivers/mtd/tests/mtd_oobtest.c:545:25: warning: Using plain integer as NULL pointer
> drivers/mtd/tests/mtd_oobtest.c:569:33: warning: Using plain integer as NULL pointer
> drivers/mtd/tests/mtd_oobtest.c:589:33: warning: Using plain integer as NULL pointer
> drivers/mtd/tests/mtd_oobtest.c:613:33: warning: Using plain integer as NULL pointer
> drivers/mtd/tests/mtd_oobtest.c:633:33: warning: Using plain integer as NULL pointer
> drivers/mtd/tests/mtd_oobtest.c:673:41: warning: Using plain integer as NULL pointer
> drivers/mtd/tests/mtd_oobtest.c:701:33: warning: Using plain integer as NULL pointer
> drivers/mtd/tests/mtd_readtest.c:74:41: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Hannes Eder <hannes@...neseder.net>
> ---
> drivers/mtd/tests/mtd_oobtest.c | 24 ++++++++++++------------
> drivers/mtd/tests/mtd_readtest.c | 2 +-
> 2 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/mtd/tests/mtd_oobtest.c b/drivers/mtd/tests/mtd_oobtest.c
> index afbc3f8..a18e8d2 100644
> --- a/drivers/mtd/tests/mtd_oobtest.c
> +++ b/drivers/mtd/tests/mtd_oobtest.c
> @@ -136,7 +136,7 @@ static int write_eraseblock(int ebnum)
> ops.ooblen = use_len;
> ops.oobretlen = 0;
> ops.ooboffs = use_offset;
> - ops.datbuf = 0;
> + ops.datbuf = NULL;
> ops.oobbuf = writebuf;
> err = mtd->write_oob(mtd, addr, &ops);
> if (err || ops.oobretlen != use_len) {
> @@ -189,7 +189,7 @@ static int verify_eraseblock(int ebnum)
> ops.ooblen = use_len;
> ops.oobretlen = 0;
> ops.ooboffs = use_offset;
> - ops.datbuf = 0;
> + ops.datbuf = NULL;
> ops.oobbuf = readbuf;
> err = mtd->read_oob(mtd, addr, &ops);
> if (err || ops.oobretlen != use_len) {
> @@ -216,7 +216,7 @@ static int verify_eraseblock(int ebnum)
> ops.ooblen = mtd->ecclayout->oobavail;
> ops.oobretlen = 0;
> ops.ooboffs = 0;
> - ops.datbuf = 0;
> + ops.datbuf = NULL;
> ops.oobbuf = readbuf;
> err = mtd->read_oob(mtd, addr, &ops);
> if (err || ops.oobretlen != mtd->ecclayout->oobavail) {
> @@ -281,7 +281,7 @@ static int verify_eraseblock_in_one_go(int ebnum)
> ops.ooblen = len;
> ops.oobretlen = 0;
> ops.ooboffs = 0;
> - ops.datbuf = 0;
> + ops.datbuf = NULL;
> ops.oobbuf = readbuf;
> err = mtd->read_oob(mtd, addr, &ops);
> if (err || ops.oobretlen != len) {
> @@ -522,7 +522,7 @@ static int __init mtd_oobtest_init(void)
> ops.ooblen = 1;
> ops.oobretlen = 0;
> ops.ooboffs = mtd->ecclayout->oobavail;
> - ops.datbuf = 0;
> + ops.datbuf = NULL;
> ops.oobbuf = writebuf;
> printk(PRINT_PREF "attempting to start write past end of OOB\n");
> printk(PRINT_PREF "an error is expected...\n");
> @@ -542,7 +542,7 @@ static int __init mtd_oobtest_init(void)
> ops.ooblen = 1;
> ops.oobretlen = 0;
> ops.ooboffs = mtd->ecclayout->oobavail;
> - ops.datbuf = 0;
> + ops.datbuf = NULL;
> ops.oobbuf = readbuf;
> printk(PRINT_PREF "attempting to start read past end of OOB\n");
> printk(PRINT_PREF "an error is expected...\n");
> @@ -566,7 +566,7 @@ static int __init mtd_oobtest_init(void)
> ops.ooblen = mtd->ecclayout->oobavail + 1;
> ops.oobretlen = 0;
> ops.ooboffs = 0;
> - ops.datbuf = 0;
> + ops.datbuf = NULL;
> ops.oobbuf = writebuf;
> printk(PRINT_PREF "attempting to write past end of device\n");
> printk(PRINT_PREF "an error is expected...\n");
> @@ -586,7 +586,7 @@ static int __init mtd_oobtest_init(void)
> ops.ooblen = mtd->ecclayout->oobavail + 1;
> ops.oobretlen = 0;
> ops.ooboffs = 0;
> - ops.datbuf = 0;
> + ops.datbuf = NULL;
> ops.oobbuf = readbuf;
> printk(PRINT_PREF "attempting to read past end of device\n");
> printk(PRINT_PREF "an error is expected...\n");
> @@ -610,7 +610,7 @@ static int __init mtd_oobtest_init(void)
> ops.ooblen = mtd->ecclayout->oobavail;
> ops.oobretlen = 0;
> ops.ooboffs = 1;
> - ops.datbuf = 0;
> + ops.datbuf = NULL;
> ops.oobbuf = writebuf;
> printk(PRINT_PREF "attempting to write past end of device\n");
> printk(PRINT_PREF "an error is expected...\n");
> @@ -630,7 +630,7 @@ static int __init mtd_oobtest_init(void)
> ops.ooblen = mtd->ecclayout->oobavail;
> ops.oobretlen = 0;
> ops.ooboffs = 1;
> - ops.datbuf = 0;
> + ops.datbuf = NULL;
> ops.oobbuf = readbuf;
> printk(PRINT_PREF "attempting to read past end of device\n");
> printk(PRINT_PREF "an error is expected...\n");
> @@ -670,7 +670,7 @@ static int __init mtd_oobtest_init(void)
> ops.ooblen = sz;
> ops.oobretlen = 0;
> ops.ooboffs = 0;
> - ops.datbuf = 0;
> + ops.datbuf = NULL;
> ops.oobbuf = writebuf;
> err = mtd->write_oob(mtd, addr, &ops);
> if (err)
> @@ -698,7 +698,7 @@ static int __init mtd_oobtest_init(void)
> ops.ooblen = mtd->ecclayout->oobavail * 2;
> ops.oobretlen = 0;
> ops.ooboffs = 0;
> - ops.datbuf = 0;
> + ops.datbuf = NULL;
> ops.oobbuf = readbuf;
> err = mtd->read_oob(mtd, addr, &ops);
> if (err)
> diff --git a/drivers/mtd/tests/mtd_readtest.c b/drivers/mtd/tests/mtd_readtest.c
> index 645e77f..79fc453 100644
> --- a/drivers/mtd/tests/mtd_readtest.c
> +++ b/drivers/mtd/tests/mtd_readtest.c
> @@ -71,7 +71,7 @@ static int read_eraseblock_by_page(int ebnum)
> ops.ooblen = mtd->oobsize;
> ops.oobretlen = 0;
> ops.ooboffs = 0;
> - ops.datbuf = 0;
> + ops.datbuf = NULL;
> ops.oobbuf = oobbuf;
> ret = mtd->read_oob(mtd, addr, &ops);
> if (ret || ops.oobretlen != mtd->oobsize) {
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists